Wireshark-commits: [Wireshark-commits] master 96783ea83: RTPS: Fixed the scenario where discovery c
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=96783ea83980fbb529ce2c7956d7bcf1c4743d75
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
96783ea83 by Juanjo Martin (juanjo@xxxxxxx):
RTPS: Fixed the scenario where discovery contains PID_EXTENDED
Before there was a wrong dissection of parameters that wasn't
predictable because of the wrong offset. This could lead to anything.
Now, it shows an expert warning indicating that the RTPS packet
doesn't contain all the bytes specified by the parameter but it shows
properly the parameterId and the length. In order to parse properly
the whole PID_EXTENDED parameter we'd need to handle fragments. That
is not the purpose of this commit.
Change-Id: I0f3f0f1d309d43a530047f510169fb07983a9fb6
Reviewed-on: https://code.wireshark.org/review/15698
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from ab82d45 AMQP: Fix false positive
adds 96783ea83 RTPS: Fixed the scenario where discovery contains PID_EXTENDED
Summary of changes:
epan/dissectors/packet-rtps.c | 43 +++++++++++++++++++++++++++--------------
1 file changed, 28 insertions(+), 15 deletions(-)