Wireshark-commits: [Wireshark-commits] master a6618ff: Move npf_sys_is_running() from wsutil to cap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jun 2016 21:25:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6618ffdc9ed8ad28aeecf902b45c39e2f3b9d93
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a6618ff by Guy Harris (guy@xxxxxxxxxxxx):

    Move npf_sys_is_running() from wsutil to caputils.
    
    It has nothing to do with controlling privileges; it only tests whether
    the NPF or Npcap service (driver) is running, so it belongs in caputils.
    
    While we're at it, fix its signature (in C, a function with no arguments
    must have "void" as the argument list, for backwards compatibility with
    pre-function-prototype C), and close the handles it opens, so we don't
    have open handles leaked.
    
    Change-Id: Ia99e99d81617ed2e8cda2c44e53061b4502a2b58
    Reviewed-on: https://code.wireshark.org/review/15714
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  018765f   Remove an ellipsis UTF-8 character in gsignal.h
    adds  a6618ff   Move npf_sys_is_running() from wsutil to caputils.


Summary of changes:
 caputils/capture-wpcap.c |   38 ++++++++++++++++++++++++++++++++++++++
 caputils/capture-wpcap.h |    8 +++++++-
 wsutil/privileges.c      |   29 -----------------------------
 wsutil/privileges.h      |    9 ---------
 4 files changed, 45 insertions(+), 39 deletions(-)