Wireshark-commits: [Wireshark-commits] master f9f8e21: Remove 'if (tree)' checks from code samples.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Jun 2016 19:27:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9f8e21a4b88d2c6efe0181bced998095bc3b440
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f9f8e21 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Remove 'if (tree)' checks from code samples.
    
    Showing 'if (tree)' constructions in code samples and then having to
    explain these are no longer nessasery, or even wrong in many cases,
    indicates that these shouldn't be in the code samples in the first
    place.
    
    Change-Id: I1a0ccc84ad24ff998548fa913bc00c0336bf1123
    Reviewed-on: https://code.wireshark.org/review/15659
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d53229d   AT: fix heuristic check
    adds  f9f8e21   Remove 'if (tree)' checks from code samples.


Summary of changes:
 docbook/wsdg_src/WSDG_chapter_dissection.asciidoc |   68 +++++++--------------
 1 file changed, 22 insertions(+), 46 deletions(-)