Wireshark-commits: [Wireshark-commits] master 987ff3e: Qt: Firewall Rules dialog.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=987ff3ee1bed5fe17d3889411687283818cee29f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
987ff3e by Gerald Combs (gerald@xxxxxxxx):
Qt: Firewall Rules dialog.
Add the Firewall ACL Rules dialog. Try showing all valid rules for a
given product instead of making the user select from a combobox. We can
add the combo back easily enough if that's desired.
Add a rule hint field and use it in the Qt and GTK+ UIs.
Bug: 12469
Change-Id: I39dd840e9838f96d7c5e2b4c34662811c21d0386
Reviewed-on: https://code.wireshark.org/review/15689
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 4b216ae Qt: Use checkboxes in the capture options dialog.
adds 987ff3e Qt: Firewall Rules dialog.
Summary of changes:
ui/CMakeLists.txt | 1 +
ui/Makefile.common | 2 +
ui/firewall_rules.c | 290 ++++++++++++++++++++
ui/firewall_rules.h | 108 ++++++++
ui/gtk/firewall_dlg.c | 252 ++---------------
ui/qt/CMakeLists.txt | 3 +
ui/qt/Makefile.am | 2 +
ui/qt/Makefile.common | 4 +
ui/qt/Wireshark.pro | 3 +
ui/qt/firewall_rules_dialog.cpp | 225 +++++++++++++++
ui/qt/{print_dialog.h => firewall_rules_dialog.h} | 80 +++---
...ic_table_dialog.ui => firewall_rules_dialog.ui} | 56 ++--
ui/qt/main_window.cpp | 7 +-
ui/qt/main_window.h | 2 +
ui/qt/main_window.ui | 42 ++-
ui/qt/main_window_slots.cpp | 16 +-
16 files changed, 767 insertions(+), 326 deletions(-)
create mode 100644 ui/firewall_rules.c
create mode 100644 ui/firewall_rules.h
create mode 100644 ui/qt/firewall_rules_dialog.cpp
copy ui/qt/{print_dialog.h => firewall_rules_dialog.h} (54%)
copy ui/qt/{traffic_table_dialog.ui => firewall_rules_dialog.ui} (60%)
