Wireshark-commits: [Wireshark-commits] master 697996a: Create a FieldFilterEdit class and apply it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 1 Jun 2016 20:35:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=697996a8b0cea260e89bab709a5b556f3ba7b1c6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

697996a by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create a FieldFilterEdit class and apply it to custom column preference field.
    
    DisplayFilterEdit deals with entire filters and some edit boxes just need a
    single protocol field.  This control will do the trick.
    
    Bug: 12321
    Change-Id: I8e5837ea9a6955ada29b7e516ea022ab1dd46f0d
    Reviewed-on: https://code.wireshark.org/review/15595
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3742662   Qt: Check for valid color filter before use
    adds  697996a   Create a FieldFilterEdit class and apply it to custom column preference field.


Summary of changes:
 ui/qt/CMakeLists.txt                               |    2 +
 ui/qt/Makefile.common                              |    2 +
 ui/qt/Wireshark.pro                                |    2 +
 ui/qt/column_preferences_frame.cpp                 |   11 +-
 ui/qt/field_filter_edit.cpp                        |  287 ++++++++++++++++++++
 .../{display_filter_edit.h => field_filter_edit.h} |   28 +-
 6 files changed, 304 insertions(+), 28 deletions(-)
 create mode 100644 ui/qt/field_filter_edit.cpp
 copy ui/qt/{display_filter_edit.h => field_filter_edit.h} (71%)