Wireshark-commits: [Wireshark-commits] master 0add74f: Restore a preference column type if fields a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 May 2016 10:41:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0add74fcc9b6a4ee433af36f5d796b319ca1f66b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0add74f by Michael Mann (mmann78@xxxxxxxxxxxx):

    Restore a preference column type if fields are empty.
    
    The column type is automatically changed to Custom if user clicks
    on the "Fields" or "Field Occurrences" column.  This can be
    accidental and cause the user grief if he doesn't realize it.
    If there is no text in the field, restore the type to its
    original value.
    
    Bug: 12465
    Change-Id: I0453f43be13077aba58cca61011eeff9ca9b83b2
    Reviewed-on: https://code.wireshark.org/review/15600
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5948eee   mgcp: remove some unnecessary if (tree) checks
    adds  0add74f   Restore a preference column type if fields are empty.


Summary of changes:
 ui/qt/column_preferences_frame.cpp |   51 +++++++++++++++++++++++++-----------
 ui/qt/column_preferences_frame.h   |    1 +
 2 files changed, 36 insertions(+), 16 deletions(-)