Wireshark-commits: [Wireshark-commits] master 18452f8: Fix a compile error: [ 17%] Building C objec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 May 2016 07:50:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18452f87af17d07febae089de39abbe11053989c
Submitter: J?rg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

18452f8 by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix a compile error:
    [ 17%] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-isup.c.o
    /Users/jmayer/worktmp/wireshark/git/epan/dissectors/packet-isup.c:3415:71: error: implicit conversion loses integer precision: 'unsigned long' to 'guint'
          (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
        e164_info.E164_number_length = wmem_strbuf_get_len(strbuf_number) - 1;
                                     ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
    1 error generated.
    
    No idea wether this fix is valid, but it got me past the error.
    
    Change-Id: I191d0dfd9d84b997d4e886ff9f5a4e76032a368e
    Reviewed-on: https://code.wireshark.org/review/15612
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  47b5836   Copy all options when creating SHB block for new file.
    adds  18452f8   Fix a compile error: [ 17%] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-isup.c.o /Users/jmayer/worktmp/wireshark/git/epan/dissectors/packet-isup.c:3415:71: error: implicit conversion loses integer precision: 'unsigned long' to 'guint'       (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]     e164_info.E164_number_length = wmem_strbuf_get_len(strbuf_number) - 1;                                  ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ 1 error ge [...]


Summary of changes:
 epan/dissectors/packet-isup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)