Wireshark-commits: [Wireshark-commits] master 3fbd397: If we're "[Saving] the file and [closing] it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 May 2016 18:11:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3fbd397d35c29c388c33944627554c47af8b66ae
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3fbd397 by Guy Harris (guy@xxxxxxxxxxxx):

    If we're "[Saving] the file and [closing] it", actually *close* it.
    
    Otherwise, if you've modified the file (added, removed, or changed
    comments), and you try to close the file or quit, and answer "Save" to
    the "save your work?" question, Wireshark tries to clean up the wmem
    scopes, but the file scope hasn't been left, and wmem crashes with an
    assertion error.
    
    (The GTK+ version does the close, so it doesn't have the bug.)
    
    Change-Id: Ie5942e415cfab1907e29b09926a62e2679aca6ee
    Reviewed-on: https://code.wireshark.org/review/15598
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a0d7121   BOOTP: Added Boot Services Discovery Protocol (BSDP)
    adds  3fbd397   If we're "[Saving] the file and [closing] it", actually *close* it.


Summary of changes:
 ui/qt/main_window.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)