Wireshark · Wireshark-commits: [Wireshark-commits] master 0482b78: Set frame/file protocol list only after dissection is complete.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0482b78a8d7dfcff9dcd8f0e9d2950e51601062d
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0482b78 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Set frame/file protocol list only after dissection is complete.
    
    The protocol list tree item used in a frame/file is near the bottom
    of items under the frame/file tree. Move it a little farther down until
    after the rest of the frame/record is dissected.  This prevents the need
    for proto_item_append_string (and its special handling)
    
    Change-Id: Iea4eaac7675126ebad642b11fa86ad211f21ae26
    Reviewed-on: https://code.wireshark.org/review/15589
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  4489341   Make wtap_optionblock_foreach_option public.
    adds  0482b78   Set frame/file protocol list only after dissection is complete.


Summary of changes:
 epan/dissectors/file-file.c    |   19 ++-----------------
 epan/dissectors/packet-frame.c |   19 ++-----------------
 2 files changed, 4 insertions(+), 34 deletions(-)