Wireshark-commits: [Wireshark-commits] master-2.0 d56cf90: Create a "placeholder" NFS CB protocol f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 May 2016 14:13:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d56cf90396e3db510e7fd72290ccf219f6f33cf8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d56cf90 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create a "placeholder" NFS CB protocol for ONC-RPC stats.
    
    In GTK GUI, "NFS" shows up twice in the ONC-RPC Service Response Time
    Programs list.  That's probably confusing enough to users.  In Qt
    the "second" NFS wasn't showing up at all (or getting overwritten)
    because it was hashing on program name.
    Make NFS programs unique with a "stubbed" protocol.
    
    Bug: 12478
    Change-Id: Ic4ebdab8ba8b70e6026e1fb0f8e8defd4532b0f2
    Reviewed-on: https://code.wireshark.org/review/15588
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1e121f3   SMB NtCreate andX with extended response sometimes incorrect
    adds  d56cf90   Create a "placeholder" NFS CB protocol for ONC-RPC stats.


Summary of changes:
 epan/dissectors/packet-nfs.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)