Wireshark-commits: [Wireshark-commits] master 9f02b25: Remove some proto_item_append_string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 May 2016 16:10:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f02b25caf3c3133f97664c74973be3b7bd60e9b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9f02b25 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove some proto_item_append_string
    
    These calls to proto_item_append_string were not taking into account all
    of the special treatment needed to use it, so proto_item_append_text
    (or similar) was probably intended.
    
    Change-Id: I5d1f092f8162a87d30fc8dc694f6124dc81372b5
    Reviewed-on: https://code.wireshark.org/review/15575
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7ca8e46   Remove write capabilities from wtap_optionblocks.
    adds  9f02b25   Remove some proto_item_append_string


Summary of changes:
 epan/dissectors/packet-ar_drone.c |    8 +++---
 epan/dissectors/packet-olsr.c     |    6 ++--
 epan/dissectors/packet-wsp.c      |   57 ++++++++++++++++++++-----------------
 3 files changed, 38 insertions(+), 33 deletions(-)