Wireshark · Wireshark-commits: [Wireshark-commits] master 7ca8e46: Remove write capabilities from wtap_optionblocks.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ca8e46ffb95a31b8df15019298f8404723e68b4
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7ca8e46 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove write capabilities from wtap_optionblocks.
    
    The write functionality was too PCAPNG-specific and the intention is to
    keep the option blocks as generic as possible.
    
    So moved the write functionality back to pcapng.c and added a
    wtap_opttype API to loop through all options in the block
    (wtap_optionblock_foreach_option)
    
    Change-Id: Iaf49126a1a3e2ed60ae02c52878ca22671dac335
    Reviewed-on: https://code.wireshark.org/review/15525
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  c0e679e   Cyclic PROFINET PROFIsafe RTC1 data dissection
    adds  7ca8e46   Remove write capabilities from wtap_optionblocks.


Summary of changes:
 wiretap/pcapng.c        |  613 ++++++++++++++++++++++++++++++++++++++++++++++-
 wiretap/wtap_opttypes.c |  445 ++--------------------------------
 wiretap/wtap_opttypes.h |   34 +--
 3 files changed, 635 insertions(+), 457 deletions(-)