Wireshark-commits: [Wireshark-commits] master 33103f3: Qt: Add next / previous sequence shortcuts.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 May 2016 04:18:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33103f3fb29629eaa0dde641bc21f88ed9469189
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

33103f3 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add next / previous sequence shortcuts.
    
    Add next (N) and previous (P) keyboard shortcuts. The GTK+ UI uses the
    down and up keys, but we're already using those for panning the Y axis.
    Add a scroll margin when using N and P.
    
    Add mouse wheel and trackpad support.
    
    Disable mouse dragging for now until we figure out how to limit it to
    our axis boundaries.
    
    Ping-Bug: 12419
    Change-Id: I292319928db365206277bf2bb3e42e14ef811ff0
    Reviewed-on: https://code.wireshark.org/review/15559
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  aaa5551   Update the comments/warnings about using proto_tree_append_string().
    adds  33103f3   Qt: Add next / previous sequence shortcuts.


Summary of changes:
 ui/qt/sequence_diagram.cpp |   47 ++++++++++++++-
 ui/qt/sequence_diagram.h   |   10 ++--
 ui/qt/sequence_dialog.cpp  |  140 ++++++++++++++++++++++++++++++--------------
 ui/qt/sequence_dialog.h    |    7 ++-
 ui/qt/sequence_dialog.ui   |   24 ++++++++
 5 files changed, 176 insertions(+), 52 deletions(-)