Wireshark-commits: [Wireshark-commits] master d8ef04c: zigbee zdp: remove some misleading casts
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 May 2016 18:00:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8ef04c8914e162139594cfe0aee3072bc513e70
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d8ef04c by Martin Kaiser (wireshark@xxxxxxxxx):

    zigbee zdp: remove some misleading casts
    
    sizeof() returns a size_t, which is unsigned
    
    when we assign the result of sizeof() to an unsigned lvalue like a
    guint, there's no point in casting to int
    
    Change-Id: I9644c72a22a6dadb9ecd4073a4fcbd1c93517b59
    Reviewed-on: https://code.wireshark.org/review/15531
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  032be8f   manolito: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  d8ef04c   zigbee zdp: remove some misleading casts


Summary of changes:
 epan/dissectors/packet-zbee-zdp.c |   30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)