Wireshark-commits: [Wireshark-commits] master 546f5aa: ERF: Fix and improve ERF_TYPE_META sanity ch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 May 2016 12:45:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=546f5aa31ba2b2733a4c1c7b62544c9b660f5726
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

546f5aa by Anthony Coddington (anthony.coddington@xxxxxxxxxx):

    ERF: Fix and improve ERF_TYPE_META sanity checks
    
    Fix sanity checking overflow in wiretap ERF_TYPE_META parsing segfault.
    Fix final tag of exactly 4 bytes not being dissected.
    Fix not setting bitfield tag subtree (was working due to proto.c internal behaviour).
    Add dissector expertinfo for truncated tags. Dissect type and length on error.
    
    Bug: 12352
    Change-Id: I3fe6644f369e4d6f1f64270cb83c8d0f8a1f1a94
    Reviewed-on: https://code.wireshark.org/review/15357
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6d0738f   Start dissecting the Mikrotik/Routerboard vendorspecific IEs
    adds  546f5aa   ERF: Fix and improve ERF_TYPE_META sanity checks


Summary of changes:
 epan/dissectors/packet-erf.c |   37 +++++++++++++++++++++++++++++++++++--
 wiretap/erf.c                |    9 ++++++---
 2 files changed, 41 insertions(+), 5 deletions(-)