Wireshark-commits: [Wireshark-commits] master 0cadb33: USB: check length before calling setup respo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 May 2016 03:38:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cadb330dd2313dac1168c811f220cb37e26f5cc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0cadb33 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    USB: check length before calling setup response subdissector
    
    If a standard setup response arrives without data, don't call a subdissector.
    This can happen if a control endpoint STALLs.
    This patch prevents the STALL response from appearing as a malformed packet.
    
    Change-Id: I6f0e82487fae964e93a4291ccb3badbe652f7499
    Reviewed-on: https://code.wireshark.org/review/15379
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3a637f3   androiddump: Add model name to user-friendly interface name
    adds  0cadb33   USB: check length before calling setup response subdissector


Summary of changes:
 epan/dissectors/packet-usb.c |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)