Wireshark-commits: [Wireshark-commits] master 55fdbd5: manolito: refactor the message parsing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 20:33:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55fdbd5346b25c588906ab5a1cf0f7d62c836c0e
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

55fdbd5 by Martin Kaiser (wireshark@xxxxxxxxx):

    manolito: refactor the message parsing
    
    Use an offset variable, increment it as we walk through the packet. Use
    tvb_reported_length_remaining() to see if we have more data.
    
    Change-Id: I7048316ee418ff3e79e391295a29d9b221079847
    Reviewed-on: https://code.wireshark.org/review/15485
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  e3a53fb   manolito: remove some pointless comments
    adds  55fdbd5   manolito: refactor the message parsing


Summary of changes:
 epan/dissectors/packet-manolito.c |  195 ++++++++++++++++++-------------------
 1 file changed, 97 insertions(+), 98 deletions(-)