Wireshark-commits: [Wireshark-commits] master c1214d2: manolito: don't use a temporary data pointer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 20:31:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1214d22073fa655c85cd05700adc4a0977d7bf0
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1214d2 by Martin Kaiser (wireshark@xxxxxxxxx):

    manolito: don't use a temporary data pointer
    
    We either have a string or an integer. Use tvb_get_string_enc() to get
    the string.
    
    Change-Id: I84a83aed5eba57817e53bb194a8e01c273abf57a
    Reviewed-on: https://code.wireshark.org/review/15482
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  dd16f65   manolito (CID 1355642): avoid shifting by 32 bits
    adds  c1214d2   manolito: don't use a temporary data pointer


Summary of changes:
 epan/dissectors/packet-manolito.c |   42 +++++++++++++++----------------------
 1 file changed, 17 insertions(+), 25 deletions(-)