Wireshark-commits: [Wireshark-commits] master cf66bdb: Qt: Delete recent items.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 11:09:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf66bdb42f7bc76f92807ee2852ce91ae4441115
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cf66bdb by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Delete recent items.
    
    QListWidget::takeItem removes an item from the list but doesn't free it.
    Call delete instead.
    
    Change-Id: I81b1315d0851518935f542c53455b283e26e5dc5
    Reviewed-on: https://code.wireshark.org/review/15474
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fe187b6   tvb_get_ptr + wmem_alloc = tvb_memdup
    adds  cf66bdb   Qt: Delete recent items.


Summary of changes:
 ui/qt/main_welcome.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)