Wireshark-commits: [Wireshark-commits] master-2.0 7b360ce: Qt: Fix a recent files infinite loop.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 04:18:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b360cebab8d171598fb4d52afc3fd87ea9f30c0
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7b360ce by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix a recent files infinite loop.
    
    QListWidget::takeItem does nothing if the row is invalid. This is the
    case when we pass it ::count(). Make sure that we remove a valid row and
    that our loop will terminate.
    
    Follow-up to g174dc98.
    
    Change-Id: I7e695cc04b2f3b5c28a8cc70af0579d787ff8737
    Reviewed-on: https://code.wireshark.org/review/15417
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 43776d4b7391874a69a706661a71f2020c05230b)
    Reviewed-on: https://code.wireshark.org/review/15475
    

Actions performed:

    from  8f8a2d0   ethertype: Add old non-standard 802.1ad (QinQ)
    adds  7b360ce   Qt: Fix a recent files infinite loop.


Summary of changes:
 ui/qt/main_welcome.cpp |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)