Wireshark · Wireshark-commits: [Wireshark-commits] master c04ee3e: ISUP: fix buffer overrun when a number contains too many digits

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c04ee3e173a7ac87a43e0f5e107b5672104a97d5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c04ee3e by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    ISUP: fix buffer overrun when a number contains too many digits (CID 1361601)
    
    Check the current length before adding the digit and not after
    While we are at it, also switch to strbuf wmem buffer instead
    
    Bug: 12442
    Change-Id: If3e80e8446f527fe8fb013fbd57828f5572ca5ee
    Reviewed-on: https://code.wireshark.org/review/15441
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ad4d0b8   Create option flag field for dissect_ieee80211_common.
    adds  c04ee3e   ISUP: fix buffer overrun when a number contains too many digits (CID 1361601)


Summary of changes:
 epan/dissectors/packet-isup.c |  174 ++++++++++++++++++++++++++---------------
 1 file changed, 113 insertions(+), 61 deletions(-)