Wireshark · Wireshark-commits: [Wireshark-commits] master a1891f6: Add filterable fields for each ISUP number.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1891f64ec7e56a38e61225ced912c65fd053793
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a1891f6 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Add filterable fields for each ISUP number.
    
    Make a common number dissection function to do this without cut-n-pasting code
    a whole bunch of times.
    
    Clean up the number dissection code while we're there:
     - Don't throw an exception when we found too many digits.  Report it (expert
       info) and move on.
     - Avoid a useless (text) subtree: use the hf for the number as the root of
       the tree.  This means using proto_tree_append_string() which adds some
       complication but it's worth it to avoid a hidden item (which was the old
       solution if we passed the number to the E.164 dissector).
    
    Bug: 12334
    Change-Id: I465cab91b216b734f5763a4e56faa8e06b0731a2
    Reviewed-on: https://code.wireshark.org/review/14924
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d12561f   Move the Valgrind size check after the capinfos check of the file.
    adds  a1891f6   Add filterable fields for each ISUP number.


Summary of changes:
 epan/dissectors/asn1/camel/camel.cnf |    8 +-
 epan/dissectors/asn1/inap/inap.cnf   |    6 +-
 epan/dissectors/packet-camel.c       |    8 +-
 epan/dissectors/packet-inap.c        |    6 +-
 epan/dissectors/packet-isup.c        |  975 ++++++++++------------------------
 epan/dissectors/packet-isup.h        |    8 +-
 6 files changed, 299 insertions(+), 712 deletions(-)