Wireshark-commits: [Wireshark-commits] master f872bdf: ERF: Fix Ethernet FCS detection and remove p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 May 2016 18:26:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f872bdf6102b25fa191a7e3faad110ae3daaead4
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f872bdf by Anthony Coddington (anthony.coddington@xxxxxxxxxx):

    ERF: Fix Ethernet FCS detection and remove preference
    
    Use eth_maybefcs instead of eth_withoutfcs.
    ERF_TYPE_ETH records almost always have FCS, but using maybe means the "Assume
    packets have FCS" is respected.
    Mark the erf_ethfcs preference as obsolete. It was being ignored.
    This was broken by Change 3670 which changed the ERF dissector to use
    a dissector table.
    
    Change-Id: I45cffdaed3890f8a0f505b2011be8c5204d9b2a6
    Reviewed-on: https://code.wireshark.org/review/15360
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d5031d5   automake/nmake: don't run checkAPIs on lex and yacc files.
    adds  f872bdf   ERF: Fix Ethernet FCS detection and remove preference


Summary of changes:
 epan/dissectors/packet-erf.c |   11 +++++------
 epan/dissectors/packet-eth.c |    5 +++--
 2 files changed, 8 insertions(+), 8 deletions(-)