Wireshark-commits: [Wireshark-commits] master b5cbbc5: s7comm: block/file up-/download redesign
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 May 2016 13:18:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5cbbc5a4057d214363809cf8ebbed741381ff5e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b5cbbc5 by Thomas Wiens (th.wiens@xxxxxx):

    s7comm: block/file up-/download redesign
    
    Redesigned the block/file up- and download, using new informations from
    PI-Services.
    Changed the block-info items, as it's in general a string, which can be
    further dissected if it's a PLC program block.
    Other types of Siemens automation hardware may use this as a simple
    filename for filetransfer.
    Changed the display-style for block name/number in info-column, to be more
    compact.
    
    Change-Id: Ie7c3a285d25897f8516ed8827041a5dbdf80679e
    Reviewed-on: https://code.wireshark.org/review/15275
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  62ccbc9   Fixed value for experimental result code 5142
    adds  b5cbbc5   s7comm: block/file up-/download redesign


Summary of changes:
 epan/dissectors/packet-s7comm.c | 1445 ++++++++++++++++++++++++++++++++-------
 1 file changed, 1210 insertions(+), 235 deletions(-)