Wireshark-commits: [Wireshark-commits] master 931603c: rawshark: Have fvalue_to_string_repr just re
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 May 2016 22:48:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=931603c4b84a5e69e94e3bfd3c84332e664062ab
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

931603c by Michael Mann (mmann78@xxxxxxxxxxxx):

    rawshark: Have fvalue_to_string_repr just return allocated string representation.
    
    Simplify use of fvalue_to_string_repr in rawshark by just having it
    return an allocated string representation of a field value instead
    of trying to find the right allocated buffer size to pass in.
    This will also allow fvalue_to_string_repr to be converted to
    exclusively return allocated strings and not accept a provided buffer.
    
    Change-Id: I9996411dca4656d599b30ed415453d0207131824
    Reviewed-on: https://code.wireshark.org/review/15342
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8237331   rawshark: Get "field string values" from existing functionality.
    adds  931603c   rawshark: Have fvalue_to_string_repr just return allocated string representation.


Summary of changes:
 rawshark.c |   23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)