Wireshark-commits: [Wireshark-commits] master-1.12 b8e0d41: WBXML: add a basic sanity check for off
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 May 2016 08:42:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8e0d416898bb975a02c1b55883342edc5b4c9c0
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b8e0d41 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    WBXML: add a basic sanity check for offset overflow
    
    This is a naive approach allowing to detact that something went wrong,
    without the need to replace all proto_tree_add_text() calls as what was
    done in master-2.0 branch.
    
    Bug: 12408
    Change-Id: Ia14905005e17ae322c2fc639ad5e491fa08b0108
    Reviewed-on: https://code.wireshark.org/review/15310
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  0a8a44c   format DIS header timestamp as mm:ss.nnnnnn
    adds  b8e0d41   WBXML: add a basic sanity check for offset overflow


Summary of changes:
 epan/dissectors/packet-wbxml.c |   28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)