Wireshark-commits: [Wireshark-commits] master 728e683: Handle the encoding when displaying the stri
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 May 2016 20:32:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=728e683b14517c6c9688666a8a7dd4ad35f807cf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

728e683 by Guy Harris (guy@xxxxxxxxxxxx):

    Handle the encoding when displaying the string table.
    
    Don't just treate the strings as piles of ASCII characters.
    
    Add a proto_tree_add_item_ret_string_and_length() routine to help do
    this.  Clean up some of the documentation of the proto_tree_add_item_ret
    routines while we're at it.
    
    Change-Id: Ib4c52bd8a8331eac97312583326f5be9175889d9
    Reviewed-on: https://code.wireshark.org/review/15291
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ac21696   The tabulation is specified by the stuff at the end.
    adds  728e683   Handle the encoding when displaying the string table.


Summary of changes:
 epan/dissectors/packet-wap.c   |   99 ++++++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-wap.h   |    3 ++
 epan/dissectors/packet-wbxml.c |   39 ++++++++--------
 epan/proto.c                   |   38 +++++++++------
 epan/proto.h                   |   51 +++++++++++++++++----
 5 files changed, 191 insertions(+), 39 deletions(-)