Wireshark-commits: [Wireshark-commits] master a68e178: s7comm: Add errorcode descriptions, extended
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 May 2016 19:45:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a68e178b2e43785716aec97c4b59b99f48bae75d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a68e178 by Thomas Wiens (th.wiens@xxxxxx):

    s7comm: Add errorcode descriptions, extended list values, style cleanup
    
    Added new errorcodes, changed to extended value-string. Removed the
    defines as they are and will not be used in the code.
    Add errorcode to info column, if there is an error.
    Removed the functioncall-tree comment, as it was not up to date.
    
    Change-Id: I0abe8eb046b9b2f28e32cf71e214704daa0aa843
    Reviewed-on: https://code.wireshark.org/review/15260
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5493fe0   Convert ftype-tvbuff.c to ftype-protocol.c
    adds  a68e178   s7comm: Add errorcode descriptions, extended list values, style cleanup


Summary of changes:
 epan/dissectors/packet-s7comm.c |  465 +++++++++++++++++++++++++--------------
 1 file changed, 300 insertions(+), 165 deletions(-)