Wireshark-commits: [Wireshark-commits] master 95d1028: QUIC: fix decode when use version > Q033
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 May 2016 08:03:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95d10287e7abe8ab55f58a8bcb1f14521362681a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

95d1028 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    QUIC: fix decode when use version > Q033
    
    With Q033, connection id (CID) flag change (only on one byte and only say 0 or 8 bytes length
    
    cid never have length 2 or 4 bytes (from old spec), see https://groups.google.com/a/chromium.org/d/msg/proto-quic/pR6FA7oyeV8/4Ec42-GrMQAJ
    
    Change-Id: I9fffe0369a8cc0811bdbc85a9c9fa8539f049981
    Reviewed-on: https://code.wireshark.org/review/15164
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  db4f7fcd  PIDL: Remove _U_ and remove unused-parameter via pragma
    adds  95d1028   QUIC: fix decode when use version > Q033


Summary of changes:
 epan/dissectors/packet-quic.c |   45 +++++++++++------------------------------
 1 file changed, 12 insertions(+), 33 deletions(-)