Wireshark-commits: [Wireshark-commits] master f69b3b1: IMAP: Add heuristic check for TLS
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 1 May 2016 23:33:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f69b3b1f0e6aa2edc3fe51e9e0fd3a28ba2f4306
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f69b3b1 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    IMAP: Add heuristic check for TLS
    
    If the IMAP TCP stream doesn't include the STARTTLS command/response
    the IMAP dissector will try to dissect TLS ciphertext as IMAP protocol
    plaintext.
    
    Add heuristic check for SSLv3/TLS and if the heuristic matches register
    dissect_ssl() as the dissector for that IMAP session.
    
    Change-Id: If84eca22315193a306e93e66c608de6634e6cd85
    Reviewed-on: https://code.wireshark.org/review/13570
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  3270dfa   Don't treat the packet length as unsigned.
    adds  f69b3b1   IMAP: Add heuristic check for TLS


Summary of changes:
 epan/dissectors/packet-imap.c      |   66 ++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-ssl-utils.c |   24 ++++++++++---
 epan/dissectors/packet-ssl-utils.h |   12 +++++++
 3 files changed, 97 insertions(+), 5 deletions(-)