Wireshark-commits: [Wireshark-commits] master 2cb5985: Make class "type" for USB conversations.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 1 May 2016 20:16:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cb5985bf47bdc8bea78d28483ed224abdd33dc6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2cb5985 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make class "type" for USB conversations.
    
    USB dissectors can't assume that only their class type has been passed around in the conversation.  Make explicit check that class type expected matches the dissector and stop/prevent dissection if there isn't a match.
    
    Bug: 12356
    Change-Id: Ib23973a4ebd0fbb51952ffc118daf95e3389a209
    Reviewed-on: https://code.wireshark.org/review/15212
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7c79da8   qt: SH_ScrollBar_Transient is not available for Qt <= 5.2
    adds  2cb5985   Make class "type" for USB conversations.


Summary of changes:
 epan/dissectors/packet-u3v.c            |    4 ++++
 epan/dissectors/packet-usb-audio.c      |    4 ++++
 epan/dissectors/packet-usb-masstorage.c |    5 ++++-
 epan/dissectors/packet-usb-video.c      |    4 ++++
 epan/dissectors/packet-usb.h            |    5 ++++-
 5 files changed, 20 insertions(+), 2 deletions(-)