Wireshark-commits: [Wireshark-commits] master b83c39e: Have daintree_sna_read_packet() do all the p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 30 Apr 2016 09:06:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b83c39e02942adf10440d91c0eafe4655642526d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b83c39e by Guy Harris (guy@xxxxxxxxxxxx):

    Have daintree_sna_read_packet() do all the packet reading work.
    
    Share more code between the read and seek-read routines.
    
    Also note why that code doesn't have to check against
    WTAP_MAX_PACKET_SIZE.
    
    Change-Id: I09086fcd3c16883c2598fb0aeb172c66f480d315
    Reviewed-on: https://code.wireshark.org/review/15193
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f29d1da   IPv4: use calculated value for Header Length display filter
    adds  b83c39e   Have daintree_sna_read_packet() do all the packet reading work.


Summary of changes:
 wiretap/daintree-sna.c |   92 +++++++++++++++++-------------------------------
 1 file changed, 32 insertions(+), 60 deletions(-)