Wireshark-commits: [Wireshark-commits] master-1.12 303680c: Fix packet length handling.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 29 Apr 2016 22:23:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=303680c3eae0263854c80845a660a1784d731533
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

303680c by Guy Harris (guy@xxxxxxxxxxxx):

    Fix packet length handling.
    
    Treat the packet length as unsigned - it shouldn't be negative in the
    file.  If it is, that'll probably cause the sscanf to fail, so we'll
    report the file as bad.
    
    Check it against WTAP_MAX_PACKET_SIZE to make sure we don't try to
    allocate a huge amount of memory, just as we do in other file readers.
    
    Use the now-validated packet size as the length in
    ws_buffer_assure_space(), so we are certain to have enough space, and
    don't allocate too much space.
    
    Bug: 12394
    Change-Id: If0b79376fc6fe2f49c7b7d7796dee7b7683485cb
    Reviewed-on: https://code.wireshark.org/review/15171
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  07713f6   OpenFlow: fix flow_monitor_request dissector
    adds  303680c   Fix packet length handling.


Summary of changes:
 wiretap/toshiba.c |   22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)