Wireshark-commits: [Wireshark-commits] master 91b1542: Win32: Pass a mutable string to CreateProces
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Apr 2016 23:50:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=91b154236bf0afb2d82d2e596528f6d35d14b4a4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

91b1542 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Win32: Pass a mutable string to CreateProcess.
    
    CreateProcess can modify its second (lpCommandLine) argument. Don't
    pass it the output of utf_8to16.
    
    Constify the return value of utf_8to16.
    
    Change-Id: I0d4361396e90c88a4ab2a3f2f0e058230e897fdf
    Reviewed-on: https://code.wireshark.org/review/15155
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  82e39fc   Don't mix g_malloc() and wmem_alloc().
    adds  91b1542   Win32: Pass a mutable string to CreateProcess.


Summary of changes:
 capchild/capture_sync.c   |   14 ++++++++++++--
 ui/win32/file_dlg_win32.c |    6 +++---
 wsutil/unicode-utils.c    |    2 +-
 wsutil/unicode-utils.h    |    2 +-
 4 files changed, 17 insertions(+), 7 deletions(-)