Wireshark-commits: [Wireshark-commits] master-2.0 119e586: Use "system" for "use system language",
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Apr 2016 19:42:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=119e5866c147755d853a82132e0cc91fcb12f837
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

119e586 by Guy Harris (guy@xxxxxxxxxxxx):

    Use "system" for "use system language", and don't try to print a null string.
    
    Add a #define USE_SYSTEM_LANGUAGE for the language string meaning "use
    the system setting", and use that instead of hardcoding "system" in
    various places.
    
    If "language" is null, don't try to write it to the file with fprintf()
    - on *most* systems, that prints "(null)", but on some systems, such as
    Solaris, it *crashes*.  Write USE_SYSTEM_LANGUAGE instead.  Check for
    "(null)" and treat it as meaning "use the system language".
    
    Map "auto" to "use the system language" as well, for backwards
    compatibility.
    
    Change-Id: I2681906e1ec18b10669b0b287c6bbcfa2fa0ebb1
    Reviewed-on: https://code.wireshark.org/review/15148
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  42cca21   Qt: Refresh the display filter toolbar layout.
    adds  119e586   Use "system" for "use system language", and don't try to print a null string.


Summary of changes:
 ui/language.c                           |   17 ++++++++++++++---
 ui/language.h                           |    2 ++
 ui/qt/main_window_preferences_frame.cpp |    2 +-
 ui/qt/wireshark_application.cpp         |    3 ++-
 4 files changed, 19 insertions(+), 5 deletions(-)