Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 485bb27: Qt: Display filter toolbar behavior tweaks.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=485bb270dca82b929719d8c57fb182882a2025d2
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

485bb27 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Display filter toolbar behavior tweaks.
    
    By default GtkToolbar shows overflow items in a menu. QToolBar shows
    them in a bigger toolbar. This is a problem for users with lots of
    display filter expressions because expanding the display filter toolbar
    can make it very tall.
    
    QToolBar can optionally overflow into a menu, but as noted in
    https://bugreports.qt.io/browse/QTBUG-2472 there isn't a way do so
    directly, e.g. with a setter. Force an overflow menu in the display
    filter toolbar by adding a child QToolBar and adding filter expression
    actions to it.
    
    While we're here, set the minimum width of the display filter edit to
    two-thirds of the width of the main window.
    
    Change-Id: I49cd58397e087f1aa79b5bbce471f827e9804148
    Reviewed-on: https://code.wireshark.org/review/15134
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 3c5a9b10b4dd6696861a62672b322807bb2bfdf6)
    Reviewed-on: https://code.wireshark.org/review/15144
    

Actions performed:

    from  971300c   OpenFlow: fix flow_monitor_request dissector
    adds  485bb27   Qt: Display filter toolbar behavior tweaks.


Summary of changes:
 ui/qt/main_window.cpp       |   12 ++++++++++++
 ui/qt/main_window.h         |    4 +++-
 ui/qt/main_window_slots.cpp |    9 +++++----
 3 files changed, 20 insertions(+), 5 deletions(-)