Wireshark-commits: [Wireshark-commits] master b1d6f39: Add expert info when Modbus/TCP packet can't
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Apr 2016 07:48:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1d6f39b53b1c316171b0f4e1735cd20199a01dc
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b1d6f39 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add expert info when Modbus/TCP packet can't be classified.
    
    The common case for this is using Decode As over the Modbus/TCP port preference.  Here the port preference is used to determine request/response because the protocol itself doesn't have any indications (so Decode As can't be helpful).  Looking into the packet itself can lead to too many false positives.
    
    Bug: 10933
    Change-Id: Ic6b4304f062f55ff273105edbb0d272c30e53506
    Reviewed-on: https://code.wireshark.org/review/15127
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  5b655d0   mp2t: support forced tcp decoding
    adds  b1d6f39   Add expert info when Modbus/TCP packet can't be classified.


Summary of changes:
 epan/dissectors/packet-mbtcp.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)