Wireshark-commits: [Wireshark-commits] master fc21652: NSIS: Pass /install to vcredist_xNN.exe.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Apr 2016 17:15:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc216521850fd5af5bf58ae5e3a90a634d087794
Submitter: Graham Bloice (graham.bloice@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fc21652 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Pass /install to vcredist_xNN.exe.
    
    Explicitly pass /install to the Visual C++ redistributable installer. A
    few people have reported issues with missing or incorrect redistributable
    files after installing Wireshark but unfortunately haven't provided
    much in the way of further detail. Is it possible that the installer
    sometimes goes into /repair, /layout, or /uninstall modes?
    
    Remove checks for old, unsupported compilers while we're here.
    
    Change-Id: I4e24dbe562c8aeb6ce63ec98ea1601cba5256806
    Reviewed-on: https://code.wireshark.org/review/15120
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    

Actions performed:

    from  f26262a   Update .mailmap (and regenerate AUTHORS)
    adds  fc21652   NSIS: Pass /install to vcredist_xNN.exe.


Summary of changes:
 packaging/nsis/wireshark.nsi |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)