Wireshark-commits: [Wireshark-commits] master-2.0 23086b3: J1939 can have 0 bytes of "packet data"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Apr 2016 18:43:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23086b3a42a666a4dd875650fb28d2963207a562
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

23086b3 by Michael Mann (mmann78@xxxxxxxxxxxx):

    J1939 can have 0 bytes of "packet data" (i.e. just CAN ID), so use tvb_reported_length instead of -1.
    
    Bug: 12366
    Change-Id: Id702572b95c3500906ce12ee9658ded132611247
    Reviewed-on: https://code.wireshark.org/review/15108
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit a4da88a3d0cc0b067c45fe8fc9c4b85a687ef6eb)
    Reviewed-on: https://code.wireshark.org/review/15110
    

Actions performed:

    from  ff0ba0a   Qt: Speed up the Display Filter Expression dialog appearance.
    adds  23086b3   J1939 can have 0 bytes of "packet data" (i.e. just CAN ID), so use tvb_reported_length instead of -1.


Summary of changes:
 epan/dissectors/packet-j1939.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)