Wireshark · Wireshark-commits: [Wireshark-commits] master 9de18e8: If you allocate with wmem, free with wmem.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9de18e88f501ef953395b8cadf9dbc9b79ce40cc
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9de18e8 by Martin Kaiser (wireshark@xxxxxxxxx):

    If you allocate with wmem, free with wmem.
    
    This g_free() causes a crash on my system for every capture file where
    names are resolved.
    
    Program received signal SIGABRT, Aborted.
    0x00007ffff0347125 in *__GI_raise (sig=<optimized out>) at
    ../nptl/sysdeps/unix/sysv/linux/raise.c:64
    64 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
    (gdb) bt
     #0  0x00007ffff0347125 in *__GI_raise (sig=<optimized out>) at
    ../nptl/sysdeps/unix/sysv/linux/raise.c:64
     #1  0x00007ffff034a3a0 in *__GI_abort () at abort.c:92
     #2  0x00007ffff038135b in __libc_message (do_abort=<optimized out>,
    fmt=<optimized out>)
        at ../sysdeps/unix/sysv/linux/libc_fatal.c:189
     #3  0x00007ffff038abb6 in malloc_printerr (action=3, str=0x7ffff0464532
    "free(): invalid pointer", ptr=<optimized out>)
        at malloc.c:6312
     #4  0x00007ffff038f95c in *__GI___libc_free (mem=<optimized out>) at
    malloc.c:3738
     #5  0x00007fffef8cca41 in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #6  0x00007fffef8ccad2 in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #7  0x00007fffef8cceea in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #8  0x00007fffef8d501b in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #9  0x00007fffef8d3a4a in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #10 0x00007fffef8d4792 in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #11 0x00007fffef8d49de in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #12 0x00007fffef8d4cc7 in ?? () from
    /usr/lib/x86_64-linux-gnu/libcares.so.2
     #13 0x00007ffff4329713 in host_name_lookup_process () at
    addr_resolv.c:2485
     #14 0x000000000053fda9 in WiresharkApplication::refreshAddressResolution
    (this=0x7fffffffe2f0) at wireshark_application.cpp:217
     #15 0x000000000059c42d in WiresharkApplication::qt_static_metacall
    (_o=0x7fffffffe2f0, _c=<optimized out>, _id=<optimized out>,
        _a=0x7fffffffd7b0) at wireshark_application.moc.cpp:142
     #16 0x00007ffff140654f in QMetaObject::activate(QObject*, QMetaObject
    const*, int, void**) ()
       from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
    
    Change-Id: I20586929463259f71f325225975eec241166f123
    Reviewed-on: https://code.wireshark.org/review/15047
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  3db13a7   Link version code statically again
    adds  9de18e8   If you allocate with wmem, free with wmem.


Summary of changes:
 epan/addr_resolv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)