Wireshark-commits: [Wireshark-commits] master c943afb: Use memcmp() to check the magic number.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Apr 2016 01:06:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c943afbdacb2bfaa94500d2eb1705541bf3ebffb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c943afb by Guy Harris (guy@xxxxxxxxxxxx):

    Use memcmp() to check the magic number.
    
    We just care whether the first 6 bytes of the file are "MPCSII";
    memcmp() will do that, and we don't have to worry about NULs.
    
    Change-Id: I03872c30e76eedce67577657270e36f0795e74bd
    Reviewed-on: https://code.wireshark.org/review/14994
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6206f34   g_list_free_full() only exists since 2.28
    adds  c943afb   Use memcmp() to check the magic number.


Summary of changes:
 wiretap/mplog.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)