Wireshark-commits: [Wireshark-commits] master-2.0 73e22ee: wslua: fix crash on Lua errors in dissec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Apr 2016 21:13:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73e22ee4d81357c2868d2d0fdeb5255b7a91a76a
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

73e22ee by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: fix crash on Lua errors in dissect_tcp_pdus get_len_func
    
    A similar problem was addressed in v1.99.10rc0-339-g82b2258, but that
    patch missed the get_pdu_len function. A crash could occur when
    get_pdu_len does not return a number or when it raises a Lua error.
    
    Change-Id: I1a42a95d88708ae3bf6e015ba8d7af4db5071a00
    Reviewed-on: https://code.wireshark.org/review/14954
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit a9ba46856cff3ec121db5ce883defbec2d1dabd4)
    Reviewed-on: https://code.wireshark.org/review/14964
    

Actions performed:

    from  808ae6b   Another help message update.
    adds  73e22ee   wslua: fix crash on Lua errors in dissect_tcp_pdus get_len_func


Summary of changes:
 epan/wslua/wslua_proto.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)