Wireshark-commits: [Wireshark-commits] master 8c3b36d: Don't assume the HTTP dissector is being cal
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Apr 2016 02:32:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c3b36deb8d3c6aa2c7ba03a4dc72cbb5602d821
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8c3b36d by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assume the HTTP dissector is being called from the TCP dissector.
    
    It's not - it could be called from the SSL dissector or the SCTP
    dissector.  Create separate dissectors for all of them; they can, if
    passed appropriate metadata in the "data" argument, process it
    appropriately for the type of metadata the calling tissector supplies.
    
    Bug: 12344
    Change-Id: I8d9a2f3173e6de42b31993bbb6c81d161f68bf8c
    Reviewed-on: https://code.wireshark.org/review/14944
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  173ccf7   More test-programs autotoolizing
    adds  8c3b36d   Don't assume the HTTP dissector is being called from the TCP dissector.


Summary of changes:
 epan/dissectors/asn1/cmp/packet-cmp-template.c |    4 +-
 epan/dissectors/packet-cmp.c                   |    4 +-
 epan/dissectors/packet-daap.c                  |    2 +-
 epan/dissectors/packet-http.c                  |  186 +++++++++++++++++-------
 epan/dissectors/packet-http.h                  |    4 +-
 epan/dissectors/packet-ipp.c                   |    2 +-
 6 files changed, 140 insertions(+), 62 deletions(-)