Wireshark · Wireshark-commits: [Wireshark-commits] master b7897dd: Qt: prevent input to the capture filter field during initializat

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7897ddecc673b6aad171564a38911e81fe29f39
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b7897dd by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: prevent input to the capture filter field during initialization
    
    Mark the capture filter field as readonly until initialization is
    completed. This avoids useless entries in the recent capture filters
    list and fixes a use-after-free when typing during startup.
    
    (This use-after free occurred when a new item is added to the recent
    filters list which invalidates the previously retrieved list).
    
    Change-Id: Ifae9444986436a60781bf5f83a6e650501ccc4d5
    Reviewed-on: https://code.wireshark.org/review/14740
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b49738e   configure.ac: Use environment variable to set VERSION_FLAVOR
    adds  b7897dd   Qt: prevent input to the capture filter field during initialization


Summary of changes:
 ui/qt/capture_filter_combo.cpp |   19 ++++++++++---------
 ui/qt/capture_filter_combo.h   |    3 ++-
 2 files changed, 12 insertions(+), 10 deletions(-)