Wireshark-commits: [Wireshark-commits] master-2.0 2d19254: Qt: Follow stream performance improvemen
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d19254b94e4aab5fccabf71194097823a20234c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
2d19254 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Follow stream performance improvements.
Make FollowStreamText a subclass of QPlainTextEdit instead of QTextEdit.
For large amounts of text, the former should be less unbearably slow
than the latter. Increase the maximum stream size to 500MB. This isn't
perfect but it's much more usable than 2MB and much easier than the next
step, which is to write our own text display widget.
Process UI events while we fill in the stream data. This gives us
behavior similar to the GTK+ UI and is similar to what we do in other
dialogs.
Switch from g_memdup+g_free to a QByteArray in the Qt UI and GByteArray
in the GTK+ UI.
Don't call readStream twice.
Make sure we free all of our stream data in the Qt UI. This fixes a
serious memory leak.
Ping-Bug: 11777
Change-Id: Ibad9bde86692ae07a80660566d1e661ab8b64601
Reviewed-on: https://code.wireshark.org/review/14271
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit f611edf4e6061003d4eca88443c54b68d500cecd)
Conflicts:
ui/gtk/follow_stream.c
ui/qt/follow_stream_dialog.cpp
Reviewed-on: https://code.wireshark.org/review/14867
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 674d8cc zvt: fix parsing of the 3-byte length field
adds 2d19254 Qt: Follow stream performance improvements.
Summary of changes:
ui/qt/follow_stream_dialog.cpp | 112 ++++++++++++++++++++++++++--------------
ui/qt/follow_stream_text.cpp | 18 +++++--
ui/qt/follow_stream_text.h | 4 +-
ui/qt/wireshark_dialog.h | 8 ++-
4 files changed, 96 insertions(+), 46 deletions(-)
