Wireshark-commits: [Wireshark-commits] master f611edf: Qt: Follow stream performance improvements.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2016 23:37:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f611edf4e6061003d4eca88443c54b68d500cecd
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f611edf by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Follow stream performance improvements.
    
    Make FollowStreamText a subclass of QPlainTextEdit instead of QTextEdit.
    For large amounts of text, the former should be less unbearably slow
    than the latter. Increase the maximum stream size to 500MB. This isn't
    perfect but it's much more usable than 2MB and much easier than the next
    step, which is to write our own text display widget.
    
    Process UI events while we fill in the stream data. This gives us
    behavior similar to the GTK+ UI and is similar to what we do in other
    dialogs.
    
    Switch from g_memdup+g_free to a QByteArray in the Qt UI and GByteArray
    in the GTK+ UI.
    
    Don't call readStream twice.
    
    Make sure we free all of our stream data in the Qt UI. This fixes a
    serious memory leak.
    
    Ping-Bug: 11777
    Change-Id: Ibad9bde86692ae07a80660566d1e661ab8b64601
    Reviewed-on: https://code.wireshark.org/review/14271
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2b2a989   Add support for the I-FORWARD-TSN chunk.
    adds  f611edf   Qt: Follow stream performance improvements.


Summary of changes:
 ui/gtk/follow_stream.c         |   13 +++--
 ui/qt/follow_stream_dialog.cpp |  104 ++++++++++++++++++++++++++--------------
 ui/qt/follow_stream_text.cpp   |   18 +++++--
 ui/qt/follow_stream_text.h     |    4 +-
 ui/qt/wireshark_dialog.h       |    8 +++-
 5 files changed, 98 insertions(+), 49 deletions(-)