Wireshark-commits: [Wireshark-commits] master ee9858f: Don't deref before NULL check on pointer (CI
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 Apr 2016 16:23:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee9858f347f54f22fbf88d2e78a53a5ada0e7018
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ee9858f by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Don't deref before NULL check on pointer (CID-1358044)
    
    When the state pointer is NULL it's defensively coded against by a
    NULL pointer check. Variable initialization before should then not
    dereference that pointer.
    
    Change-Id: I0ed09e2f22be5651324f43fc3fd339d2f95684c0
    Reviewed-on: https://code.wireshark.org/review/14776
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  c5b2c1e   reassemble: remove special treatment for truncated data
    adds  ee9858f   Don't deref before NULL check on pointer (CID-1358044)


Summary of changes:
 wiretap/erf.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)