Wireshark-commits: [Wireshark-commits] master-1.12 df3d07b: replace dangerous tvb_get_ptr with safe
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Apr 2016 23:09:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df3d07b4bf80decf504cb007b9a73c85a3eef737
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

df3d07b by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    replace dangerous tvb_get_ptr with safer string function.
    
    Using tvb_get_ptr to get a string is always dangerous in the face of
    malformed packets. Instead using string functions allow for safe handling
    of these.
    
    Bug: 12242
    Change-Id: Id5a57a3d9ab744386b3358d378fe9e0e62df54fa
    Reviewed-on: https://code.wireshark.org/review/14769
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  edf4950   GSM CBCH: fix an out of bounds access
    adds  df3d07b   replace dangerous tvb_get_ptr with safer string function.


Summary of changes:
 epan/dissectors/packet-pktc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)