Wireshark-commits: [Wireshark-commits] master fd4808f: Qt: Remember selected item in packet tree
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd4808fbec986bcc24247b9acfba83db95dba2c6
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
fd4808f by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: Remember selected item in packet tree
Previously, changing a packet in the packet list would lose the
currently selected field item in the packet tree. After this patch, this
issue no longer occurs because the selected field is focussed again.
The approach is to remember the header field ID on the path from a field
to its root. Limitations of the current simple approach is that multiple
fields/trees under a tree might result in the wrong selection. This is
better than nothing though.
This patch greatly helps analyzing a capture file which has the same
format, except that I need to check a data source for decrypted data.
Previously I would have to scroll down and select the field to see the
data source which also made it impossible to quickly switch between
packets and compare them.
Change-Id: Ic113ca9245fd9faa10f91182794c50cfde8d10f4
Reviewed-on: https://code.wireshark.org/review/14697
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 959fe0e Qt: Keep byte tab when reloading/closing capture file
adds fd4808f Qt: Remember selected item in packet tree
Summary of changes:
ui/qt/packet_list.cpp | 2 ++
ui/qt/proto_tree.cpp | 40 ++++++++++++++++++++++++++++++++++++++++
ui/qt/proto_tree.h | 3 +++
3 files changed, 45 insertions(+)
