Wireshark · Wireshark-commits: [Wireshark-commits] master a2c0424: Qt: Lazily create dialogs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2c042471b86499606028fa09208c0f3df1cf07a
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a2c0424 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Lazily create dialogs.
    
    According to the Visual Studio 2013 profiler here, we spend about 4% of
    our startup time creating the Capture Interfaces dialog. Hold off on
    doing that until the user wants to see the dialog. Do the same for the
    File Set dialog.
    
    While we're here, make sure MainWindow has fewer children when setupUi
    is called. setupUi calls connectSlotsByName, which iterates over all
    child objects.
    
    Change-Id: I253e6dc5b7e73a6cb7b7036637e336f449449c4a
    Reviewed-on: https://code.wireshark.org/review/14732
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  e6a65af   Qt: Try to speed up SplashOverlay
    adds  a2c0424   Qt: Lazily create dialogs.


Summary of changes:
 ui/qt/main_window.cpp       |   47 ++++++++++--------------------
 ui/qt/main_window.h         |    8 ++---
 ui/qt/main_window_slots.cpp |   68 ++++++++++++++++++++++++++++++++-----------
 3 files changed, 71 insertions(+), 52 deletions(-)